lkml.org 
[lkml]   [1997]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ioctl(fd, KDMKTONE, arg)
Bob Tracy - TDS:

: The PCMCIA cardmgr utility no longer generates beeps as of 2.1.49.
: Something in the last patch set seems to have affected
: ioctl(fd, KDMKTONE, arg). A quick check of the return value from
: ioctl() doesn't indicate any errors occurring.

Hmm - sorry for reacting too quickly - all I said was
correct, and patch-2.1.49 should indeed have updated _kd_mksound()
as indicated, but the real reason things went wrong was that
KDMKTONE now calls kd_mksound() with arg truncated to an integer,
while in fact it should have been truncated to 16 bits.
So, this simple patch introduced two bugs.

No doubt the inventor will correct things.


\
 
 \ /
  Last update: 2005-03-22 13:40    [W:0.036 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site