Messages in this thread | | | Date | Wed, 13 Aug 1997 23:03:53 +0200 (MET DST) | From | Andries.Brouwer@cwi ... | Subject | Re: ioctl(fd, KDMKTONE, arg) |
| |
Bob Tracy - TDS:
: The PCMCIA cardmgr utility no longer generates beeps as of 2.1.49. : Something in the last patch set seems to have affected : ioctl(fd, KDMKTONE, arg). A quick check of the return value from : ioctl() doesn't indicate any errors occurring.
Hmm - sorry for reacting too quickly - all I said was correct, and patch-2.1.49 should indeed have updated _kd_mksound() as indicated, but the real reason things went wrong was that KDMKTONE now calls kd_mksound() with arg truncated to an integer, while in fact it should have been truncated to 16 bits. So, this simple patch introduced two bugs.
No doubt the inventor will correct things.
| |