Messages in this thread Patch in this message | | | From | (Miquel van Smoorenburg) | Subject | Re: pre-2.0.31 problems | Date | 14 May 1997 14:10:17 +0200 |
| |
In article <199705140959.LAA01413@mvmap66.ciw.uni-karlsruhe.de>, Thomas Koenig <Thomas.Koenig@ciw.uni-karlsruhe.de> wrote: >David Miller wrote: > >>Please apply the 3 patches Eric sent in 3 seperate mails to >>linux-kernel this morning, they fix various crashes/problems related >>to SYN cookies. > >Which were these? I only got > >"Patch to fix TCP window offerings with low rcvbuf." and "YATCPP >(Yet another TCP patch): writev coallesing". Did the rest somehow >not make it out to me?
The was another one called "" (no subject....). Here it is:
> From: Eric.Schenk@dna.lth.se > Subject: (none) > Date: 12 May 1997 22:01:23 +0200 > Message-ID: <199705121844.UAA28966@rekk.dna.lth.se>
The following patch should be applied over pre-2.0.31 to prevent a memory leak and probably crash when using SYN cookies. Please apply this patch if you are testing pre-2.0.31.
Thanks,
diff -u -r1.19.2.15 -r1.19.2.16 --- tcp_output.c 1997/05/06 13:43:19 1.19.2.15 +++ tcp_output.c 1997/05/08 20:25:39 1.19.2.16 @@ -1004,7 +1004,10 @@ } #endif tcp_send_check(t1, newsk->saddr, newsk->daddr, sizeof(*t1)+4, buff); - newsk->prot->queue_xmit(newsk, ndev, buff, destroy); + if (destroy) + newsk->prot->queue_xmit(NULL, ndev, buff, 1); + else + newsk->prot->queue_xmit(newsk, ndev, buff, 0); #ifdef CONFIG_SYN_COOKIES -- Eric Schenk www: http://www.dna.lth.se/~erics Dept. of Comp. Sci., Lund University email: Eric.Schenk@dna.lth.se Box 118, S-221 00 LUND, Sweden fax: +46-46 13 10 21 ph: +46-46 222 96 38
-- | Miquel van Smoorenburg | "I need more space" "Well, why not move to Texas" | | miquels@cistron.nl | "No, on my account, stupid." "Stupid? Uh-oh.." | | PGP fingerprint: FE 66 52 4F CD 59 A5 36 7F 39 8B 20 F1 D6 74 02 |
| |