Messages in this thread | | | From | Paul Gortmaker <> | Subject | Re: CONFIG_SERIAL_CONSOLE in v2.1.31 | Date | Mon, 7 Apr 1997 13:38:05 +1000 (EST) |
| |
> > > My only minor gripe is that you still can't select the serial port without > > having to locate and edit some #define buried in some file. > > I was lazy and did not make it any better than it was before in this > respect. > > However, wouldn't it be better to just have added > > if [ "$CONFIG_SERIAL_CONSOLE" = "y" ]; then > int ' Serial console port' CONFIG_SERIAL_CONSOLE_PORT 0 > fi > > the serial.c was already prepared for this.
I used the "choice" function instead of "int" since we can then restrict the user to a sensible value. With the above, people who don't have a clue could enter "4" thinking COM4, and the results would not be nice if CONFIG_SERIAL_MANY_PORTS was not defined (i.e. rs_table with only 0 -> 3). Also, with "choice" they explicitly see that it is ttyS<x> that we are asking for so there is no ambiguity. Was just trying to keep it idiot-proof.
Paul.
| |