Messages in this thread | | | Date | Tue, 23 Dec 1997 22:53:35 -0600 (CST) | From | Phil Brutsche <> | Subject | Re: [PATCH] Intel clock speed detection |
| |
On Tue, 23 Dec 1997, Nicholas J. Leon wrote:
> Fellow kernel enthusiasts - > [stuff snipped] > > Here are the problems I know I haven't addressed: > > . does my mhz detection routine work reliably (ie, at all) > with all non-intel cpu's? Yes, it'll work, to a point. I haven't any experience with this on AMD chips, but on Cyrix chips these routines tend to measure the clock speed, not what is performs like. ie a cyrix PR166+ will return 133MHz because it runs at 133MHz. They are close to 100% correct on intel chips. > . what about SMP machines? There shouldn't be a problem; a SMP guru will end up proving me wrong though :-). > . slight variation of reported mhz (132 vs 133) Try allowing for some difference; some routines allow the following for their chips: A tolerance of 2MHz for '386's A tolerance of 4MHz for '486's A tolerance of 5MHz for Pentiums, PPros, and PIIs. > . struct cpu_model_info now has redundant elements of "Pentium" > (since I removed the 60/66, 75+). I'm not sure how these are > referenced in the first place, so I didn't compact them together > (as they should be). > > Please, take the time and look at what I've done. I know its not > anything amazing, but since the kernel isn't written in Perl, there's > not a lot I can contribute :) This, however, might be one of those > things I _can_ do. > > Thank you for your time! > > [ patch attached ] > > > ___________________________________________________________________________ > > simple is elegant nicholas@binary9.net > ___________________________________________________________________________ >
---------------------------------------------------------------------- Phil Brutsche
"Be of stout heart, Number One. We've handled the Borg. We can certainly handle Admiral Jellico." - Jean-Luc Picard
----------------------------------------------------------------------
| |