lkml.org 
[lkml]   [1997]   [Oct]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 30 Oct 1997 14:05:10 -0500
FromBill Hawes <>
Subjectsmbfs patch for 2.1.60
I've finally resolved the problems with smbfs and Win 95 directories,
and the attached patch should work well with all Win* (and Samba)
servers.

The problem turned out to be with one of the performance changes I made:
to avoid repeatedly copying name strings, I returned a reference to the
name in the message packet, rather than copying it to a temporary
buffer.  But the old code was adding a null byte to the names, even
though we already know its length.  For certain name lengths there isn't
any room in the SMB message packet for a null, so it was overwriting the
length of the next entry.  This then caused the directory scan to
repeatedly return the next name entry.

Enticement to beta testers: with this version you should note markedly
better performance, especially on directory scans.

Regards,
Bill[unhandled content-type:application/x-gzip]
\
 
 \ /
  Last update: 2005-03-22 13:40    [from the cache]
©2003-2008