Messages in this thread Patch in this message |  | | | Date | Wed, 29 Oct 1997 00:56:13 -0800 (PST) | | From | Gordon Chaffee <> | | Subject | Re: Compile problem with 2.1.60 |
| |
Richard B. Johnson writes: > > It seems as though ISO9660 file-systems now needs codepages????
No, just a minor problem in the code not being properly ifdefed. Apply this patch, and turn off CONFIG_JOLIET, and then you don't have to care about what Joliet is.
--- linux-2.1.60/fs/isofs/dir.c.orig Sun Oct 26 20:14:03 1997 +++ linux-2.1.60/fs/isofs/dir.c Tue Oct 28 07:11:10 1997 @@ -205,11 +205,12 @@ continue; } } - +#ifdef CONFIG_JOLIET if (inode->i_sb->u.isofs_sb.s_joliet_level) { len = get_joliet_filename(de, inode, tmpname); p = tmpname; } else { +#endif map = 1; if (inode->i_sb->u.isofs_sb.s_rock) { len = get_rock_ridge_filename(de, tmpname, inode); @@ -228,7 +229,9 @@ len = de->name_len[0]; } } +#ifdef CONFIG_JOLIET } +#endif if (len > 0) { if (filldir(dirent, p, len, filp->f_pos, inode_number) < 0) break;
> I will not even be asked about 'code pages'. Further, if I say 'Y' to > the ISO9660 file-system, I then have to say 'Y' to a repeated code-page > prompt. If I don't say 'Y', the compile will show undefined references > relating to Joliet extensions.
I tested the config stuff with both menuconfig and xconfig. The missing piece that you need was native language support, or CONFIG_NLS. Of course, with the above patch, that wouldn't be a problem either. As for the two cases of answering yet to Native language support, it makes the selection much cleaner for menuconfig and xconfig. The same option shows up on both the filesystems panel and the native language support panel. The logic was that people who were selecting filesystems might not be able to select vfat and joliet without first selecting native language support, and native language support was on an entirely different panel. While I apologize that you have to choose the same option twice in the old make config, I think that it is the lesser of two evils.
- Gordon
|  |