lkml.org 
[lkml]   [1996]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: patch: nfsroot does'nt compile in 1.3.78
Date
> Uh, IMHO this is not a proper patch.
>
> If linux/if_arp.h needs linux/netdevice.h for working properly, it should
> include it.

If we apply that everywhere we load tons of surplus includes, longer compile
times and lots more config dependant files. This is bad.

> Again IMHO, it's not a good idea to depend on the authors of every .c file
> to remember all these subtle include file dependencies. That kind of
> knowledge belongs in one place. There's only one place it _can_ go
> (#include's in the header file itself), thus that is where it should be.

I vote we cat every include file into one giant "big.h" to avoid future
problems then ...

Alan


\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.351 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site