lkml.org 
[lkml]   [1996]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Small bug in 1.3.76
On Thu, 21 Mar 1996, Boris Tobotras wrote:

> > > In arch/i386/kernel/setup.c there should be "break" in cases inside
> > > the switch where i486model and i586model gets called (sorry, haven't
> > > sources handy).
> >
> >
> > Why?
> >
> > static const char * getmodel (int x86, int model)
> > {
> > switch (x86) {
> > case 4:
> > return i486model(model);
> > case 5:
> > return i586model(model);
> > }
> > return "Unknown";
> > }
> >
> > looks fine to me. 'return' is a wonderful thing.

This is not the same setup.c as I have from a supposedly 1.3.76 kernel
source tree. Patched upgrades from .71.

switch (x86) {
case 4:
p = i486model(model);
case 5:
p = i586model(model);
}
if (p)
return p;

This seems wrong to me. The model does turn out to be correct in my case
since I do have a 586 though. :)

Greg.



\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.038 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site