Messages in this thread | | | Date | Sat, 4 May 2024 16:37:55 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 07/16] x86/mce/amd: Simplify DFR handler setup |
| |
On Thu, May 02, 2024 at 08:48:34PM +0200, Robert Richter wrote: > The general approach to use the preprogrammed offsets looks good to > me. Though, existing code [1] checks the offset and reapplies a > hardcoded value of 2 if it is zero. I don't know the history of > this. However, it would be great if that code could be simplified.
Whatever we do, the best approach is to leave old hw as it is - you don't want to "rework" all this and break some obscure old configuration which only one user has and debugging on it is hard, to say the least.
So for everyone's sake, do a cutoff at Zen, leave the pre-Zen machines support as it is and go wild with Zen and SMCA and so on, where we can still test on all kinds of hw.
And as always, ask yourself whether any "simplification" you're thinking of, is even worth the effort and is not just code churn without any real advantages.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |