Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 18 May 2024 12:44:19 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: rawnand: rockchip: reject NVDDR timings when checked |
| |
Hi Val,
I might propose a slightly different title which I think better describes the situation: "mtd: rawnand: rockchip: ensure NVDDR timings are rejected"
val@packett.cool wrote on Sat, 18 May 2024 00:31:13 -0300:
> .setup_interface first gets called with a negative "target" value
Just as an FYI, the fact that it is negative is an implementation detail, but you mention the #define of the value below, so that's fine.
> NAND_DATA_IFACE_CHECK_ONLY, in which case an error is expected > if the controller driver does not support the timing mode (NVDDR). >
Here I would welcome two tags in order to get this backported as early as needed in stable kernels:
Cc: stable@vger.kernel.org Fixes: a9ecc8c814e9 ("mtd: rawnand: Choose the best timings, NV-DDR included")
> Signed-off-by: Val Packett <val@packett.cool> > --- > Hello everyone, first Linux patch from a long time FreeBSD person :) > > This was required to get the NAND controller to attach on the random > old RK3066 tablet I'm bringing up mainline on.
Welcome! The fix looks right besides minor nits in the commit log. I'll probably take the v2 when it's out after -rc1 has been tagged.
Thanks, Miquèl
| ![\](/images/icornerr.gif) |