Messages in this thread | | | Date | Fri, 17 May 2024 23:58:41 +0100 | Subject | Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg_info' | From | Bryan O'Donoghue <> |
| |
On 17/05/2024 12:19, Dr. David Alan Gilbert wrote: >> If you look at the V1 I had >> ''gpi_desc' seems like it was never used. >> Remove it.' >> >> but Frank suggested copying the subject line; so I'm not sure >> whether you want more or less! >> >> I could change this to: >> >> 'gpi_desc' was never used since it's initial >> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > Oops, of course I mean 'reg_info' which is what I fixed in v2. > >> Would you be OK with that? > Dave > >> Dave
Hi Dave,
I saw your v1 interaction after commenting but, I still think commits that say "this removes a data structure" should elaborate more.
"This structure is no longer used since commit: 12charsubshahere" or "This structure was never used and should be considered dead code"
I generally hope the intention of my commits is clear from the code with the commit log adding whatever context or elaboration on top.
So that's what I'm suggesting here. A bit of commit log sugar on top which elaborates on and justifies the change.
--- bod
| |