lkml.org 
[lkml]   [2024]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/13] regmap: add A2B support
On Fri, May 17, 2024 at 02:58:00PM +0200, Alvin Šipraga wrote:

> +static int regmap_a2b_write(void *context, const void *data, size_t count)
> +{

> + for (i = 0; i < count - 1; i++) {
> + ret = bus->ops->write(bus, node, reg + i, d[i + 1]);
> + if (ret)
> + return ret;
> + }

Just force single_read and single_write (looks like you'll need to add
the hook for the bus there).

> +struct regmap *__devm_regmap_init_a2b_node(struct a2b_node *node,
> + const struct regmap_config *config,
> + struct lock_class_key *lock_key,
> + const char *lock_name)
> +{
> + return __devm_regmap_init(&node->dev, &regmap_a2b, node, config,
> + lock_key, lock_name);
> +}
> +EXPORT_SYMBOL_GPL(__devm_regmap_init_a2b_node);

Should there be validation of val_bits?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 18:30    [W:0.980 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site