Messages in this thread | | | Date | Fri, 17 May 2024 07:06:29 -0700 | From | Breno Leitao <> | Subject | Re: [PATCH v3] perf list: Fix the --no-desc option |
| |
On Thu, May 16, 2024 at 01:15:23PM -0700, Ian Rogers wrote: > On Thu, May 16, 2024 at 6:18 AM Breno Leitao <leitao@debian.org> wrote: > > > > Currently, the --no-desc option in perf list isn't functioning as > > intended. > > > > This issue arises from the overwriting of struct option->desc with the > > opposite value of struct option->long_desc. Consequently, whatever > > parse_options() returns at struct option->desc gets overridden later, > > rendering the --desc or --no-desc arguments ineffective. > > > > To resolve this, set ->desc as true by default and allow parse_options() > > to adjust it accordingly. This adjustment will fix the --no-desc > > option while preserving the functionality of the other parameters. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > --- > > Changelog: > > > > v3: > > * Applied the same logic to default_print_metric() and > > json_print_event() functions, as identified by Ian Rogers. > > I don't think we should change the json behavior. We're generating a > dictionary and the consumer of the dictionary isn't obligated to read > all of it. I tested the non-json output and it all looks good.
Thanks. Let me remove the json part then, and send a new version.
| |