lkml.org 
[lkml]   [2024]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems
On Tue, Jun 13, 2023 at 10:44:51AM +0200, Daniel Lezcano wrote:
> On 29/05/2023 18:20, Icenowy Zheng wrote:
> > In the commit I reverted as the first commit of this patchset, the
> > of_iomap function call, which allows multiple mapping of the same
> > physical memory space, is replaced to calling devm_of_iomap, which
> > registers exclusivity, and on my system (mt8173-elm), preventing display
> > from working.
> >
> > So I reverted it, and to really solve the problem that the original
> > commit wants to solve, I read the source of auxadc-thermal and realized
> > that the address of these two memory blocks are not saved after probe,
> > and they're only used when initializing the thermal sensors. This leads
> > to my final fix, which is the second commit here, that adds of_iounmap
> > just to the probe function.
> >
> > Icenowy Zheng (2):
> > Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid resource
> > leak in mtk_thermal_probe"
> > thermal/drivers/mediatek: unmap foreign MMIO after probing
> >
> > drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++-----------
> > 1 file changed, 24 insertions(+), 22 deletions(-)
>
> I'll apply only the revert and let you revisit the patch 2 which could be
> improved.

What's the issue with patch 2/2? It looks okay to me.

regards,
dan carpenter


\
 
 \ /
  Last update: 2024-05-27 18:30    [W:0.062 / U:2.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site