Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 17 May 2024 11:36:44 +0200 | From | Takashi Iwai <> | Subject | Re: [RESEND PATCH v5 1/3] ASoC: tas2781: Fix wrong loading calibrated data sequence |
| |
On Fri, 17 May 2024 11:20:36 +0200, Shenghao Ding wrote: > > Remove declaration of unused API which load calibrated data in wrong > sequence, changed the copyright year and correct file name in license > header. > > Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver") > Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
First off, this breaks the build. You are removing the function that is still called. You will remove the caller in a later patch, but it's still there at this point. That's what Andy suggested for the whole time.
Try to apply only this patch and build module. You'll get a compile error. This must be avoided.
Second, it makes little sense to split the patches in that way. A copyright year change can be folded into the same patch. If any, a patch to correct the ifdef as a separate patch, as it's completely irrelevant with the fix itself.
thanks,
Takashi
| ![\](/images/icornerr.gif) |