Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: Userland swsusp failure (mm-related) | Date | Sun, 9 Apr 2006 00:47:16 +0200 |
| |
Hi,
On Saturday 08 April 2006 18:15, Pavel Machek wrote: > > > This is my first (and unique) failure since I began testing uswsusp > > > (2.6.17-rc1 version). It happened (I think) because more than 50% of > > > physical memory was occupied at suspend time (about 550 megs out og > > > 1G) and that was what I was trying to test. After freeing some memory > > > suspend worked (there was no need to reboot). > > > > Well, it looks like we didn't free enough RAM for suspend in this case. > > Unfortunately we were below the min watermark for ZONE_NORMAL and > > we tried to allocate with GFP_ATOMIC (Nick, shouldn't we fall back to > > ZONE_DMA in this case?). > > > > I think we can safely ignore the watermarks in swsusp, so probably > > we can set PF_MEMALLOC for the current task temporarily and reset > > it when we have allocated memory. Pavel, what do you think? > > Seems little hacky but okay to me. > > Should not fixing "how much to free" computation to free a bit more be > enough to handle this?
Yes, but in that case we'll leave some memory unused. ;-)
Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |