Messages in this thread | | | Date | Sat, 8 Apr 2006 10:12:31 +0200 | From | Francois Romieu <> | Subject | Re: [PATCH] PCI Error Recovery: e100 network device driver |
| |
Linas Vepstas <linas@austin.ibm.com> : > Index: linux-2.6.17-rc1/drivers/net/e100.c > =================================================================== > --- linux-2.6.17-rc1.orig/drivers/net/e100.c 2006-04-07 16:21:46.000000000 -0500 > +++ linux-2.6.17-rc1/drivers/net/e100.c 2006-04-07 18:10:52.411266545 -0500 [...] > +static pci_ers_result_t e100_io_error_detected(struct pci_dev *pdev, pci_channel_state_t state)
80 cols limit.
[...] > +static pci_ers_result_t e100_io_slot_reset(struct pci_dev *pdev) > +{ > + struct net_device *netdev = pci_get_drvdata(pdev); > + struct nic *nic = netdev_priv(netdev); > + > + if (pci_enable_device(pdev)) { > + printk(KERN_ERR "e100: Cannot re-enable PCI device after reset.\n");
- The driver supports {get/set}_msglevel. Please consider using netif_msg_xxx (see include/linux/netdevice.h).
- s/e100/DRV_NAME/ (or netdev->name, or pci_name(...) depending on the context).
[...] > +static struct pci_error_handlers e100_err_handler = { > + .error_detected = e100_io_error_detected, > + .slot_reset = e100_io_slot_reset, > + .resume = e100_io_resume, > +};
Nit: I'd rather follow the style in the declaration of e100_driver.
-- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |