Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 7 Apr 2006 15:56:19 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH rc1-mm] de_thread: fix deadlockable process addition |
| |
Andrew Morton <akpm@osdl.org> wrote: > > Oleg Nesterov <oleg@tv-sign.ru> wrote: > > > > - if (likely(p->tasks.prev != LIST_POISON2)) > > + if (likely(p->tasks.prev != LIST_POISON2)) { > > argh. > > c'mon guys, we can't put a dependency on list_head poisoning into generic > code. >
A suitable fix might be to add a new list_del_poison() (or list_del_rcu_something()?) and use that everywhere.
But it should use a different poisoning pattern, so we know that the kernel will still work correctly when someone removes the list_head debugging. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |