Messages in this thread | ![/](/images/icornerl.gif) | | From | Bjorn Helgaas <> | Subject | Re: 2.6.17-rc1-mm1 | Date | Thu, 6 Apr 2006 08:55:27 -0600 |
| |
On Thursday 06 April 2006 04:34, Russell King wrote: > On Thu, Apr 06, 2006 at 11:21:54AM +0100, Russell King wrote: > > On Wed, Apr 05, 2006 at 04:01:08PM -0600, Bjorn Helgaas wrote: > > > [PATCH] vgacon: make VGA_MAP_MEM take size, remove extra use > > > > Ah, seems to be what I just suggested... > > > > > @@ -1020,14 +1019,14 @@ > > > char *charmap; > > > > > > if (vga_video_type != VIDEO_TYPE_EGAM) { > > > - charmap = (char *) VGA_MAP_MEM(colourmap); > > > + charmap = (char *) VGA_MAP_MEM(colourmap, 0); > > > > Don't like this though - can't we pass a real size here rather than zero? > > There seems to be several clues as to the maximum size:
I didn't like it either, but was too lazy to work out the actual size, so I just preserved the previous behavior.
Andrew's put my first patch in -mm already, so I'll put this size issue and your unmap suggestion on my to-do list. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |