Messages in this thread | | | Date | Wed, 5 Apr 2006 15:44:45 +0200 | From | Martin Samuelsson <> | Subject | Re: [-mm patch] drivers/media/video/bt866.c: small fixes |
| |
On Wed, 5 Apr 2006 00:42:12 -0700 Andrew Morton <akpm@osdl.org> wrote:
> Martin Samuelsson <sam@home.se> wrote: > > > > This should fix all things Andrew pointed out when I first submitted the > > avs6eyes driver. > > We still have all that #ifdef MODULE stuff at the end of bt866.c. > (Shouldn't it have module_init() and module_exit() handlers?)
I'm sorry for the confusion. I simply didn't want to cause a conflict with Adrian's patch, and canceled out those things from my version.
> All those ".input_mux = 0," lines you added to the struct initialisation > are unneeded - the compiler did that for you.
Ah. I didn't know that. It's noted, and will be used in the future. I added them mostly in an attempt to aim for clarity and completeness.
Regards, /Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |