Messages in this thread Patch in this message | | | Date | Wed, 5 Apr 2006 14:57:54 +0900 | From | Horms <> | Subject | Re: [PATCH] kexec: typo in machine_kexec() |
| |
On Tue, Apr 04, 2006 at 08:05:57PM -0700, Randy.Dunlap wrote: > On Wed, 5 Apr 2006 08:48:08 +0900 Horms wrote: > > > Signed-Off-By: Horms <horms@verge.net.au > > > > machine_kexec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Can you use diffstat -p1 ? does git allow/support that option, so that > more complete filenames are visible?
Sure, I have done that. I actually use a script to grab the changelog (of my local commit), do the diffstat, and get the patch, as I'm not sure how to get git to do that in one pass.
> > - * The more common model is are caches where the behide > > + * The more common model is are caches where the behind > > Also delete /are/, but that sentence and the previous one still need some > work, so fixing "behide" isn't a big deal IMO. However, Eric can decide > about the patch; he is the kexec maintainer.
Yeah, I puzzled over it a bit which is why I send in my original (poor) fix. Removing the are helps a lot. Here is an updated patch which is marginally better than my first pass.
kexec: comment fixes in machine_kexec()
arch/i386/kernel/machine_kexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
720f4f4a47cf856a705b59875c099770d3b4bd5f diff --git a/arch/i386/kernel/machine_kexec.c b/arch/i386/kernel/machine_kexec.c index f73d737..d31d250 100644 --- a/arch/i386/kernel/machine_kexec.c +++ b/arch/i386/kernel/machine_kexec.c @@ -194,7 +194,7 @@ NORET_TYPE void machine_kexec(struct kim * set them to a specific selector, but this table is never * accessed again you set the segment to a different selector. * - * The more common model is are caches where the behide + * The more common model is caches where the behind * the scenes work is done, but is also dropped at arbitrary * times. * - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |