Messages in this thread | | | From | Andreas Gruenbacher <> | Subject | Re: [PATCH] modules_install must not remove existing modules | Date | Thu, 6 Apr 2006 00:21:36 +0200 |
| |
On Thursday 06 April 2006 00:12, Sam Ravnborg wrote: > The removal was introduced to get rid of old modules from an earlier > build of the same kernel with potential more modules. > I was obvious when I played with an allmodconfig kernel IIRC.
The in-tree modules all install below kernel/, so I don't see why removing the external modules directory (extra or whatever) is necessary for that. It might still be that there are other external modules below /lib/modules/$KERNELRELEASE, though.
> The usecase you have in mind is with external modules only?
Yes, with more than one set of them, each of which using modules_install.
> We could special case in that suation and avoid the removal. > > I see no way to detect when it is OK to remove or not, so in the > principle of least suprise I prefer having the removal unconditional for > normal kernel builds, and no removal for external modules. > > OK?
That would be okay for me, yes.
Thanks, Andreas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |