Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 28 Apr 2006 14:59:01 +0300 (EEST) | From | Pekka J Enberg <> | Subject | Re: IP1000 gigabit nic driver |
| |
Hi David,
On Fri, 28 Apr 2006, David Gómezz wrote: > Ok, i could take care of that, and it's a good way of getting my hands > dirty with kernel programming ;). David, if it's ok to you i'll do the > cleanup thing.
Here are some suggestions for coding style cleanups:
- Use Lindet for initial formatting - Kill use of LINUX_VERSION_CODE macro for compatability - Kill obfuscating macros. For example, IPG_DEV_KFREE_SKB and IPG_DEVICE_TYPE. - Move changelogs outside of source files - Convert kmalloc/memset to kzalloc and kcalloc - Remove redundant typecasts - Remove dead code - Use dev_{dbg,err,info,warn} for logging - Remove unnecessary curly braces - Use proper naming convention for things like Length and pPHYParam - Convert macro functions to static inline functions for type safety
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |