Messages in this thread | | | Date | Fri, 28 Apr 2006 11:23:37 +0200 | From | Pavel Machek <> | Subject | Re: [RFC][PATCH] swsusp: support creating bigger images |
| |
Hi!
> OK, I'm waiting for Nick to respond, then. :-) > > Still I'd like to change one more thing in the final patch. Namely, > instead of this: > > @@ -153,6 +153,10 @@ static int snapshot_ioctl(struct inode * > case SNAPSHOT_UNFREEZE: > if (!data->frozen) > break; > + if (data->ready && in_suspend) { > + error = -EPERM; > + break; > + } > down(&pm_sem); > thaw_processes(); > enable_nonboot_cpus(); > > I'd like to do: > > case SNAPSHOT_UNFREEZE: > if (!data->frozen) > break; > + if (data->ready) > + swsusp_free(); > down(&pm_sem); > thaw_processes(); > enable_nonboot_cpus(); > > so unfreeze() won't return the error.
Seems okay to me... Pavel -- Thanks for all the (sleeping) penguins. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |