lkml.org 
[lkml]   [2006]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] I386 convert pae wmb to non smp
Date

On 27 Apr 2006, at 04:30, Nick Piggin wrote:

>> The name is pretty confused. smp_wmb seems to imply an SMP-only
>> barrier, whereas we want here a write barrier on regular memory.
>
> That is just a compiler barrier (barrier()). A CPU should always be
> consistent with
> itself so memory ordering doesn't really apply there (hence smp_
> prefix, which also
> are compiler barriers, of course).

This would be an issue of consistency between a CPU and its TLB, so I
doubt the usual self-consistency argument would hold. I would consider
the TLB as logically external and separate from the core execution
logic of the CPU. Of course it's an academic point either way since no
PAE-capable x86 processor ever reorders stores to WB memory -- my
original point was simply that smp_wmb() is a misleading name in this
context, even barrier() would be clearer imo, but I'm in no way a Linux
abstract memory model expert.

-- Keir

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-27 10:26    [W:0.678 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site