Messages in this thread | | | Date | Wed, 26 Apr 2006 16:52:15 -0400 | From | Mark Lord <> | Subject | Re: [PATCH] drivers/scsi/sd.c: fix uninitialized variable in handling medium errors |
| |
Mark Lord wrote: > >When scsi_get_sense_info_fld() fails (returns 0), it does NOT update the >value of first_err_block. But sd_rw_intr() merrily continues to use that >variable regardless, possibly making incorrect decisions about retries and the like. > >This patch removes the randomness there, by using the first sector of the >request (SCpnt->request->sector) in such cases, instead of first_err_block.
Note that this bug has been around for a while, and is also present in 2.6.16.xx. This same patch applies there too.
Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |