Messages in this thread | | | Date | Wed, 26 Apr 2006 16:03:16 -0400 | From | Jeff Garzik <> | Subject | Re: [git patch] fuse fixes |
| |
Miklos Szeredi wrote: > Linus, > > Please pull from 'for-linus' branch of > master.kernel.org:/pub/scm/linux/kernel/git/mszeredi/fuse.git
Reading the code... > struct fuse_req *fuse_request_alloc(void) > { > struct fuse_req *req = kmem_cache_alloc(fuse_req_cachep, SLAB_KERNEL); > if (req) > fuse_request_init(req); > return req; > }
This function is called from everywhere, and so, it looks like it should use SLAB_NOFS rather than SLAB_KERNEL. I would audit every GFP_KERNEL and SLAB_KERNEL usage, and consider replacing with SLAB_NOFS or GFP_NOFS.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |