Messages in this thread | | | Date | Tue, 25 Apr 2006 22:18:13 -0700 | From | Greg KH <> | Subject | Re: [patch 3/3] use kref for bio |
| |
On Wed, Apr 26, 2006 at 07:13:44AM +0200, Jens Axboe wrote: > On Wed, Apr 26 2006, Al Viro wrote: > > On Wed, Apr 26, 2006 at 10:11:02AM +0800, Akinobu Mita wrote: > > > Use kref for reference counter of bio. > > > This patch also removes BUG_ON() for freeing unreferenced bio. > > > But kref can detect it if CONFIG_DEBUG_SLAB is enabled. > > > > *Ugh* > > > > Let's _not_. It's extra overhead for no good reason. > > Completely agree. That goes for the other block layer kref patches as > well.
I also agree, there's a reason I never tried to convert them in the past :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |