Messages in this thread | | | Date | Tue, 25 Apr 2006 12:53:37 +0800 | From | Akinobu Mita <> | Subject | Re: [patch 2/4] kref debugging config option |
| |
On Mon, Apr 24, 2006 at 02:38:45PM -0700, Andrew Morton wrote: > Akinobu Mita <mita@miraclelinux.com> wrote: > > > > This patch converts all WARN_ON() in kref code to BUG_ON(). > > Why? This change will irritate testers and will decrease their ability to > capture (and hence report) diagnostic info.
I have no grudge against this BUG_ON().
But BUG_ON() is more prominent than WARN_ON(). Because I often could not realized whether WARN_ON() happned or not.
Should we make warn_counter which will be increment when WARN_ON() happens, and export it as /proc/warn-counter? (also export die_counter as /proc/die-counter) Then I'll make pretty gnome applet.
Or put the shell script which just do "dmesg | grep $warn_on_pattern".
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |