Messages in this thread | | | Subject | Re: [PATCH 1/1] threads_max: Simple lockout prevention patch | From | Pekka Enberg <> | Date | Mon, 24 Apr 2006 17:11:35 +0300 |
| |
On 4/24/06, Al Boldi <a1426z@gawab.com> wrote: > > > Like so? > > > if (nr_threads >= max_threads) > > > if (p->pid != su_pid) > > > goto bad_fork_cleanup_count; > > > > It's better to combine the two if statements into one with &&.
On Mon, 2006-04-24 at 16:53 +0300, Al Boldi wrote: > I thought of combining them too, but was afraid of some compile optimization > issues. Remember, this code-path is executed for each and every fork in the > system, thus it's highly performance sensitive.
There shouldn't be any difference. What compiler optimizations are you referring to? Did you study the generated object code?
Pekka
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |