Messages in this thread | | | Date | Fri, 21 Apr 2006 11:57:32 +0300 | From | "Pekka Enberg" <> | Subject | Re: [patch] mm: introduce remap_vmalloc_range (pls. drop previous patchset) |
| |
Hi Nick,
On 4/21/06, Nick Piggin <npiggin@suse.de> wrote: > + addr = (void *)((unsigned long)addr + (pgoff << PAGE_SHIFT));
As Andrew said, you can get rid of the casting with:
addr += pgoff << PAGE_SHIFT;
> + do { > + struct page *page = vmalloc_to_page(addr); > + ret = vm_insert_page(vma, uaddr, page); > + if (ret) > + return ret; > + > + uaddr += PAGE_SIZE; > + addr = (void *)((unsigned long)addr+PAGE_SIZE);
Same here.
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |