lkml.org 
[lkml]   [2006]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/5] mm: remap_vmalloc_range
Nick Piggin <npiggin@suse.de> wrote:
>
> Add a remap_vmalloc_range and get rid of as many remap_pfn_range and
> vm_insert_page loops as possible.
>
> remap_vmalloc_range can do a whole lot of nice range checking even
> if the caller gets it wrong (which it looks like one or two do).
>
>
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) {
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
> - if (remap_pfn_range(vma, start, page + vma->vm_pgoff,
> - PAGE_SIZE, vma->vm_page_prot))
> - if (remap_pfn_range(vma, addr, pfn, PAGE_SIZE, PAGE_READONLY))

You've removed the ability for the caller to set the pte protections - it
now always uses vma->vm_page_prot.

please explain...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-21 09:22    [W:0.079 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site