Messages in this thread | | | Date | Fri, 21 Apr 2006 00:17:12 -0700 | From | Andrew Morton <> | Subject | Re: [patch 1/5] mm: remap_vmalloc_range |
| |
Nick Piggin <npiggin@suse.de> wrote: > > Add a remap_vmalloc_range and get rid of as many remap_pfn_range and > vm_insert_page loops as possible. > > remap_vmalloc_range can do a whole lot of nice range checking even > if the caller gets it wrong (which it looks like one or two do). > > > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) { > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) { > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) { > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) { > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) { > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) > - if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) > - if (remap_pfn_range(vma, start, page + vma->vm_pgoff, > - PAGE_SIZE, vma->vm_page_prot)) > - if (remap_pfn_range(vma, addr, pfn, PAGE_SIZE, PAGE_READONLY))
You've removed the ability for the caller to set the pte protections - it now always uses vma->vm_page_prot.
please explain... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |