Messages in this thread | | | Date | Fri, 21 Apr 2006 22:56:39 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 13/16] GFS2: Makefiles and Kconfig |
| |
On Fri, Apr 21, 2006 at 11:07:53AM -0600, Matthew Wilcox wrote: > On Fri, Apr 21, 2006 at 06:53:51PM +0200, Adrian Bunk wrote: > > On Fri, Apr 21, 2006 at 10:49:10AM -0600, Matthew Wilcox wrote: > > > On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote: > > > > - "depends on SYSFS" instead of the select > > > > > > Why? It's more natural to select it rather than depend on it. > > > > The rule of thumb is that an option is either user visible and should be > > depended on or not user visible and should be select'ed. > > What rubbish! Who came up with this rule of thumb? Currently menuconfig makes it a very difficult job to undo a select. Homework: try to do "make allmodconfig" and then set CONFIG_HOTPLUG=n
You will be hit by CONFIG_FW_LOADER that is 'selected' by many instances - and then it becomes very difficult. So until menuconfig has better support for undoing select the rule of thumb outlined by Adrian is true.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |