Messages in this thread | | | Date | Fri, 21 Apr 2006 17:18:00 +0200 | From | Jörn Engel <> | Subject | Re: [PATCH/RFC] s390: Hypervisor File System |
| |
On Fri, 21 April 2006 17:42:28 +0300, Pekka Enberg wrote: > On 4/21/06, Michael Holzheu <holzheu@de.ibm.com> wrote: > > diff -urpN linux-2.6.16/fs/hypfs/hypfs.h linux-2.6.16-hypfs/fs/hypfs/hypfs.h > > --- linux-2.6.16/fs/hypfs/hypfs.h 1970-01-01 01:00:00.000000000 +0100 > > +++ linux-2.6.16-hypfs/fs/hypfs/hypfs.h 2006-04-21 12:56:58.000000000 +0200 > > +static void inline remove_trailing_blanks(char *string) > > +{ > > + char *ptr; > > + for (ptr = string + strlen(string) - 1; ptr > string; ptr--) { > > + if (*ptr == ' ') > > + *ptr = 0; > > + else > > + break; > > + } > > +} > > Please consider moving this to lib/string.c and perhaps renaming it to > strstrip().
If you do that, could you strip all whitespace? I have a special function to kill a single newline, if present. Looks to me like those two could be combined.
Jörn
-- The wise man seeks everything in himself; the ignorant man tries to get everything from somebody else. -- unknown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |