Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: kfree(NULL) | From | Daniel Walker <> | Date | Fri, 21 Apr 2006 07:06:58 -0700 |
| |
On Fri, 2006-04-21 at 03:22 -0400, James Morris wrote: > On Fri, 21 Apr 2006, Daniel Walker wrote: > > > I included a patch , not like it's needed . Recently I've been > > evaluating likely/unlikely branch prediction .. One thing that I found > > is that the kfree function is often called with a NULL "objp" . In fact > > it's so frequent that the "unlikely" branch predictor should be inverted! > > Or at least on my configuration. > > It would be helpful to collect some stats on this so we can look at the > ratio.
On my system it was roughly 31 million kfree(NULL) calls, to 4 million calls with other values . That was over 4 hours of run time .
Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |