Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 20 Apr 2006 11:30:56 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] Remove softlockup from invalidate_mapping_pages. |
| |
On Thu, Apr 20 2006, Neil Brown wrote: > On Thursday April 20, akpm@osdl.org wrote: > > > Cc: "Steinar H. Gunderson" <sgunderson@bigfoot.com> > > > Signed-off-by: Neil Brown <neilb@suse.de> > > > > > > ### Diffstat output > > > ./mm/truncate.c | 10 ++++------ > > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > > > diff ./mm/truncate.c~current~ ./mm/truncate.c > > > --- ./mm/truncate.c~current~ 2006-04-20 15:27:22.000000000 +1000 > > > +++ ./mm/truncate.c 2006-04-20 15:38:20.000000000 +1000 > > > @@ -238,13 +238,11 @@ unsigned long invalidate_mapping_pages(s > > > for (i = 0; i < pagevec_count(&pvec); i++) { > > > struct page *page = pvec.pages[i]; > > > > > > - if (TestSetPageLocked(page)) { > > > - next++; > > > + next = page->index+1; > > > + > > > + if (TestSetPageLocked(page)) > > > continue; > > > - } > > > - if (page->index > next) > > > - next = page->index; > > > - next++; > > > + > > > if (PageDirty(page) || PageWriteback(page)) > > > goto unlock; > > > if (page_mapped(page)) > > > > We're not supposed to look at page->index of an unlocked page. > > We're not? Does Jens know that? > __generic_file_splice_read seems to violate this principle!
Hmmm, where?
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |