lkml.org 
[lkml]   [2006]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/7] Have ia64 use add_active_range() and free_area_init_nodes
    Date

    Size zones and holes in an architecture independent manner for ia64.

    This has only been compile-tested due to lack of a suitable test machine.


    arch/ia64/Kconfig | 3 +
    arch/ia64/mm/contig.c | 60 +++++----------------------------------
    arch/ia64/mm/discontig.c | 41 +++-----------------------
    arch/ia64/mm/init.c | 12 +++++++
    arch/x86_64/mm/k8topology.c | 3 -
    include/asm-ia64/meminit.h | 1
    6 files changed, 30 insertions(+), 90 deletions(-)

    Signed-off-by: Mel Gorman <mel@csn.ul.ie>
    diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/Kconfig linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/Kconfig
    --- linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/Kconfig 2006-04-03 04:22:10.000000000 +0100
    +++ linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/Kconfig 2006-04-18 10:21:13.000000000 +0100
    @@ -352,6 +352,9 @@ config NUMA
    Access). This option is for configuring high-end multiprocessor
    server systems. If in doubt, say N.

    +config ARCH_POPULATES_NODE_MAP
    + def_bool y
    +
    # VIRTUAL_MEM_MAP and FLAT_NODE_MEM_MAP are functionally equivalent.
    # VIRTUAL_MEM_MAP has been retained for historical reasons.
    config VIRTUAL_MEM_MAP
    diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/mm/contig.c linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/mm/contig.c
    --- linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/mm/contig.c 2006-04-03 04:22:10.000000000 +0100
    +++ linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/mm/contig.c 2006-04-18 10:21:13.000000000 +0100
    @@ -26,10 +26,6 @@
    #include <asm/sections.h>
    #include <asm/mca.h>

    -#ifdef CONFIG_VIRTUAL_MEM_MAP
    -static unsigned long num_dma_physpages;
    -#endif
    -
    /**
    * show_mem - display a memory statistics summary
    *
    @@ -212,18 +208,6 @@ count_pages (u64 start, u64 end, void *a
    return 0;
    }

    -#ifdef CONFIG_VIRTUAL_MEM_MAP
    -static int
    -count_dma_pages (u64 start, u64 end, void *arg)
    -{
    - unsigned long *count = arg;
    -
    - if (start < MAX_DMA_ADDRESS)
    - *count += (min(end, MAX_DMA_ADDRESS) - start) >> PAGE_SHIFT;
    - return 0;
    -}
    -#endif
    -
    /*
    * Set up the page tables.
    */
    @@ -232,47 +216,24 @@ void __init
    paging_init (void)
    {
    unsigned long max_dma;
    - unsigned long zones_size[MAX_NR_ZONES];
    #ifdef CONFIG_VIRTUAL_MEM_MAP
    - unsigned long zholes_size[MAX_NR_ZONES];
    + unsigned long nid = 0;
    unsigned long max_gap;
    #endif

    - /* initialize mem_map[] */
    -
    - memset(zones_size, 0, sizeof(zones_size));
    -
    num_physpages = 0;
    efi_memmap_walk(count_pages, &num_physpages);

    max_dma = virt_to_phys((void *) MAX_DMA_ADDRESS) >> PAGE_SHIFT;

    #ifdef CONFIG_VIRTUAL_MEM_MAP
    - memset(zholes_size, 0, sizeof(zholes_size));
    -
    - num_dma_physpages = 0;
    - efi_memmap_walk(count_dma_pages, &num_dma_physpages);
    -
    - if (max_low_pfn < max_dma) {
    - zones_size[ZONE_DMA] = max_low_pfn;
    - zholes_size[ZONE_DMA] = max_low_pfn - num_dma_physpages;
    - } else {
    - zones_size[ZONE_DMA] = max_dma;
    - zholes_size[ZONE_DMA] = max_dma - num_dma_physpages;
    - if (num_physpages > num_dma_physpages) {
    - zones_size[ZONE_NORMAL] = max_low_pfn - max_dma;
    - zholes_size[ZONE_NORMAL] =
    - ((max_low_pfn - max_dma) -
    - (num_physpages - num_dma_physpages));
    - }
    - }
    -
    max_gap = 0;
    + efi_memmap_walk(register_active_ranges, &nid);
    efi_memmap_walk(find_largest_hole, (u64 *)&max_gap);
    if (max_gap < LARGE_GAP) {
    vmem_map = (struct page *) 0;
    - free_area_init_node(0, NODE_DATA(0), zones_size, 0,
    - zholes_size);
    + free_area_init_nodes(max_dma, max_dma,
    + max_low_pfn, max_low_pfn);
    } else {
    unsigned long map_size;

    @@ -284,19 +245,14 @@ paging_init (void)
    efi_memmap_walk(create_mem_map_page_table, NULL);

    NODE_DATA(0)->node_mem_map = vmem_map;
    - free_area_init_node(0, NODE_DATA(0), zones_size,
    - 0, zholes_size);
    + free_area_init_nodes(max_dma, max_dma,
    + max_low_pfn, max_low_pfn);

    printk("Virtual mem_map starts at 0x%p\n", mem_map);
    }
    #else /* !CONFIG_VIRTUAL_MEM_MAP */
    - if (max_low_pfn < max_dma)
    - zones_size[ZONE_DMA] = max_low_pfn;
    - else {
    - zones_size[ZONE_DMA] = max_dma;
    - zones_size[ZONE_NORMAL] = max_low_pfn - max_dma;
    - }
    - free_area_init(zones_size);
    + add_active_range(0, 0, max_low_pfn);
    + free_area_init_nodes(max_dma, max_dma, max_low_pfn, max_low_pfn);
    #endif /* !CONFIG_VIRTUAL_MEM_MAP */
    zero_page_memmap_ptr = virt_to_page(ia64_imva(empty_zero_page));
    }
    diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/mm/discontig.c linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/mm/discontig.c
    --- linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/mm/discontig.c 2006-04-03 04:22:10.000000000 +0100
    +++ linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/mm/discontig.c 2006-04-18 10:21:13.000000000 +0100
    @@ -636,6 +636,7 @@ static __init int count_node_pages(unsig
    {
    unsigned long end = start + len;

    + add_active_range(node, start >> PAGE_SHIFT, end >> PAGE_SHIFT);
    mem_data[node].num_physpages += len >> PAGE_SHIFT;
    if (start <= __pa(MAX_DMA_ADDRESS))
    mem_data[node].num_dma_physpages +=
    @@ -660,9 +661,8 @@ static __init int count_node_pages(unsig
    void __init paging_init(void)
    {
    unsigned long max_dma;
    - unsigned long zones_size[MAX_NR_ZONES];
    - unsigned long zholes_size[MAX_NR_ZONES];
    unsigned long pfn_offset = 0;
    + unsigned long max_pfn = 0;
    int node;

    max_dma = virt_to_phys((void *) MAX_DMA_ADDRESS) >> PAGE_SHIFT;
    @@ -679,46 +679,17 @@ void __init paging_init(void)
    #endif

    for_each_online_node(node) {
    - memset(zones_size, 0, sizeof(zones_size));
    - memset(zholes_size, 0, sizeof(zholes_size));
    -
    num_physpages += mem_data[node].num_physpages;
    -
    - if (mem_data[node].min_pfn >= max_dma) {
    - /* All of this node's memory is above ZONE_DMA */
    - zones_size[ZONE_NORMAL] = mem_data[node].max_pfn -
    - mem_data[node].min_pfn;
    - zholes_size[ZONE_NORMAL] = mem_data[node].max_pfn -
    - mem_data[node].min_pfn -
    - mem_data[node].num_physpages;
    - } else if (mem_data[node].max_pfn < max_dma) {
    - /* All of this node's memory is in ZONE_DMA */
    - zones_size[ZONE_DMA] = mem_data[node].max_pfn -
    - mem_data[node].min_pfn;
    - zholes_size[ZONE_DMA] = mem_data[node].max_pfn -
    - mem_data[node].min_pfn -
    - mem_data[node].num_dma_physpages;
    - } else {
    - /* This node has memory in both zones */
    - zones_size[ZONE_DMA] = max_dma -
    - mem_data[node].min_pfn;
    - zholes_size[ZONE_DMA] = zones_size[ZONE_DMA] -
    - mem_data[node].num_dma_physpages;
    - zones_size[ZONE_NORMAL] = mem_data[node].max_pfn -
    - max_dma;
    - zholes_size[ZONE_NORMAL] = zones_size[ZONE_NORMAL] -
    - (mem_data[node].num_physpages -
    - mem_data[node].num_dma_physpages);
    - }
    -
    pfn_offset = mem_data[node].min_pfn;

    #ifdef CONFIG_VIRTUAL_MEM_MAP
    NODE_DATA(node)->node_mem_map = vmem_map + pfn_offset;
    #endif
    - free_area_init_node(node, NODE_DATA(node), zones_size,
    - pfn_offset, zholes_size);
    + if (mem_data[node].max_pfn > max_pfn)
    + max_pfn = mem_data[node].max_pfn;
    }

    + free_area_init_nodes(max_dma, max_dma, max_pfn, max_pfn);
    +
    zero_page_memmap_ptr = virt_to_page(ia64_imva(empty_zero_page));
    }
    diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/mm/init.c linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/mm/init.c
    --- linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/ia64/mm/init.c 2006-04-03 04:22:10.000000000 +0100
    +++ linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/ia64/mm/init.c 2006-04-18 10:21:13.000000000 +0100
    @@ -539,6 +539,18 @@ find_largest_hole (u64 start, u64 end, v
    last_end = end;
    return 0;
    }
    +
    +int __init
    +register_active_ranges(u64 start, u64 end, void *nid)
    +{
    + BUG_ON(nid == NULL);
    + BUG_ON(*(unsigned long *)nid >= MAX_NUMNODES);
    +
    + add_active_range(*(unsigned long *)nid,
    + __pa(start) >> PAGE_SHIFT,
    + __pa(end) >> PAGE_SHIFT);
    + return 0;
    +}
    #endif /* CONFIG_VIRTUAL_MEM_MAP */

    static int __init
    diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/x86_64/mm/k8topology.c linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/x86_64/mm/k8topology.c
    --- linux-2.6.17-rc1-104-x86_64_use_init_nodes/arch/x86_64/mm/k8topology.c 2006-04-18 10:20:25.000000000 +0100
    +++ linux-2.6.17-rc1-105-ia64_use_init_nodes/arch/x86_64/mm/k8topology.c 2006-04-18 10:21:13.000000000 +0100
    @@ -149,9 +149,6 @@ int __init k8_scan_nodes(unsigned long s

    prevbase = base;

    - e820_register_active_regions(nodeid,
    - nodes[nodeid].start >> PAGE_SHIFT,
    - nodes[nodeid].end >> PAGE_SHIFT);
    node_set(nodeid, nodes_parsed);
    }

    diff -rup -X /usr/src/patchset-0.5/bin//dontdiff linux-2.6.17-rc1-104-x86_64_use_init_nodes/include/asm-ia64/meminit.h linux-2.6.17-rc1-105-ia64_use_init_nodes/include/asm-ia64/meminit.h
    --- linux-2.6.17-rc1-104-x86_64_use_init_nodes/include/asm-ia64/meminit.h 2006-04-03 04:22:10.000000000 +0100
    +++ linux-2.6.17-rc1-105-ia64_use_init_nodes/include/asm-ia64/meminit.h 2006-04-18 10:21:13.000000000 +0100
    @@ -56,6 +56,7 @@ extern void efi_memmap_init(unsigned lon
    extern unsigned long vmalloc_end;
    extern struct page *vmem_map;
    extern int find_largest_hole (u64 start, u64 end, void *arg);
    + extern int register_active_ranges (u64 start, u64 end, void *arg);
    extern int create_mem_map_page_table (u64 start, u64 end, void *arg);
    #endif

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-04-18 15:05    [W:5.908 / U:1.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site