lkml.org 
[lkml]   [2006]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] MacBook Pro touchpad support
From
In article <1145358431.14816.18.camel@localhost> (at Tue, 18 Apr 2006 13:07:11 +0200), Nicolas Boichat <nicolas@boichat.ch> says:

> @@ -147,13 +164,22 @@ MODULE_PARM_DESC(debug, "Activate debugg
> /* Checks if the device a Geyser 2 (ANSI, ISO, JIS) */
> static inline int atp_is_geyser_2(struct atp *dev)
> {
> - int16_t productId = le16_to_cpu(dev->udev->descriptor.idProduct);
> + int productId = le16_to_cpu(dev->udev->descriptor.idProduct);
>
> return (productId == GEYSER_ANSI_PRODUCT_ID) ||
> (productId == GEYSER_ISO_PRODUCT_ID) ||
> (productId == GEYSER_JIS_PRODUCT_ID);
> }

Any good reasons to change this?

>
> +static inline int atp_is_geyser_3(struct atp *dev)
> +{
> + int productId = le16_to_cpu(dev->udev->descriptor.idProduct);
> +
> + return (productId == GEYSER3_ANSI_PRODUCT_ID) ||
> + (productId == GEYSER3_ISO_PRODUCT_ID) ||
> + (productId == GEYSER3_JIS_PRODUCT_ID);
> +}
> +
> static int atp_calculate_abs(int *xy_sensors, int nb_sensors, int fact,
> int *z, int *fingers)
> {

If no, use int16 productId.

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-18 14:25    [W:0.102 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site