lkml.org 
[lkml]   [2006]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Alsa-devel] Re: Patch for AICA sound support on SEGA Dreamcast
From
Date
On Mon, 2006-04-03 at 17:52 +0200, Takashi Iwai wrote:

> > +static void __exit aica_exit(void)
> > +{
> > +
> > + if (likely(dreamcastcard->card)) {
>
> You don't need such an optimization in this place at all.
>
> > + snd_aicapcm_free(dreamcastcard);
> > + snd_card_free(dreamcastcard->card);
> > + kfree(dreamcastcard);
> > + if (likely(pd)) {
> > + struct device_driver *drv = (&pd->dev)->driver;
> > + device_release_driver(&pd->dev);
> > + driver_unregister(drv);
> > + platform_device_unregister(pd);
> > + }
>
> This should be in remove callback.
>

What is the remove callback?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-15 21:37    [W:0.076 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site