Messages in this thread | | | Date | Wed, 12 Apr 2006 13:51:43 -0700 (PDT) | Subject | Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff | From | "David S. Miller" <> |
| |
From: Ben Greear <greearb@candelatech.com> Date: Wed, 12 Apr 2006 13:10:06 -0700
> What is the reasoning for this change? Is the compiler > able to optomize the right-hand-side to a constant with your > change in place? > > > - if (veth->h_vlan_proto != __constant_htons(ETH_P_8021Q)) { > > + if (veth->h_vlan_proto != htons(ETH_P_8021Q)) { > > return -EINVAL; > > }
As a policy, Ben, we only use __constant_htons() in compile time initializers of data structures. Otherwise we use the normal htons().
That's why. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |