Messages in this thread | | | Date | Tue, 11 Apr 2006 11:18:34 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/7] tpm: reorganize sysfs files - Updated patch |
| |
Kylene Jo Hall <kjhall@us.ibm.com> wrote: > > > Does that look OK? > > No this is not ok because in several of these cases the response to the > command is longer than tpm_cap thus the reason for the hardcoded size.
OK.
> I can put in a max function though that compares the size of the > response and the tpm_cap. The read functions will make sure the > response does not overflow the buffer should that length ever change in > the future.
Well, pretty much anything which will automatically increase the size of that array in response to changing data structures would suit, thanks.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |