Messages in this thread | | | Subject | Re: [PATCH] de_thread: Don't confuse users do_each_thread. | From | (Eric W. Biederman) | Date | Tue, 11 Apr 2006 00:18:00 -0600 |
| |
Ingo Oeser <ioe-lkml@rameria.de> writes:
> Hi Eric, > > On Tuesday, 11. April 2006 01:16, you wrote: >> I can't seem to send out a correct patch out today with out >> sending it twice. I accidently grabbed my old version >> that sent to many arguments to detach_pid and so would not >> compile. Oops. > > While you are at it: Could you please avoid calculating current over > and over again? > > Just calculate it once and use the task_struct pointer. > > If I do this for some random occurances of "current" in fs/exec.c I get this > on Linus' latest git tree: > > text data bss dec hex filename > 9501 84 12 9597 257d old/fs/exec.o > 9386 84 12 9482 250a new/fs/exec.o > > Do you see any side effects, except reduced size > and increased performance here?
Not that I know of. I was cleaning up pids and signaling and wound up in fixing de_thread. It is just an ugly beast.
> Is a patch doing this for the whole file welcome, if you are too busy?
I could probably spare a couple of minutes to help review such a patch. Beyond de_thread I'm to busy to write such a patch.
Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |