Messages in this thread | | | Date | Mon, 10 Apr 2006 11:40:21 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH] deinline some functions in aic7xxx drivers, save 80k of text |
| |
Rolf Eike Beer wrote: > Denis Vlasenko wrote: >> I am leaving it up to maintainer to decide. After all, the driver >> is for multiple OSes, other OS may lack mdelay(). > > The comment says about multiple milliseconds sleeps which just don't happen.
Given what ah{c,d}_delay are (OS dependent wrappers) and how they are used (definitely not for multi-msec delays), they should just be changed into a #define ah{c,d}_delay(us) udelay(us) or into void inline ah{c,d}_delay(long us) {udelay(us);}. -- Stefan Richter -=====-=-==- -=-- -=-=- http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |