lkml.org 
[lkml]   [2006]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [linux-usb-devel] compile error when building multiple EHCI host controllers as modules
Date

On Apr 10, 2006, at 2:11 PM, David Brownell wrote:

>
>> +
>> +#ifdef CONFIG_PPC_83xx
>> + retval = platform_driver_register(&ehci_fsl_dr_driver);
>> + if (retval < 0)
>> + return retval;
>> +
>> + retval = platform_driver_register(&ehci_fsl_dr_driver);
>> + if (retval < 0)
>> + return retval;
>> +#endif
>> +
>> +#ifdef CONFIG_SOC_AU1X00
>> + pr_debug(DRIVER_INFO " (Au1xxx)\n");
>> +
>> + retval = driver_register(&ehci_hcd_au1xxx_driver);
>> + if (retval < 0)
>> + return retval;
>> +#endif
>
> Can we just get away from all of that extra #ifdeffery?
>
> This is essentially the same patch you sent the first time.
> With the same bugs ... like, not cleaning up the first driver
> after errors registering the second one.

Let me find a brown paper bag. The patch was suppose to be based on
what you sent me fixed up to build and run for arch/powerpc...
Clearly that's not the case. Let me work on a new version.

- k
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-10 21:18    [W:5.369 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site